Repository navigation
Add apps team to CODEOWNERS for apps changelog fragments - #6949
Merged
Merged
Conversation
Add eng-apps-devex as co-owner of .nextchanges/cli/apps-*.md, mirroring the Artifact Registry docker-*.md rule, so apps PRs that add a changelog fragment don't need a separate CLI maintainer approval. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused rule preserves maintainer ownership and follows established CODEOWNERS patterns.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Apps team ownership for Apps-specific CLI changelog fragments.
Changes:
- Adds Apps and CLI maintainers as co-owners of
apps-*.mdfragments. - Mirrors the existing Docker changelog ownership pattern.
| File | Description |
|---|---|
.github/CODEOWNERS |
Adds scoped ownership for Apps changelog fragments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Integration test reportCommit: 798ac17
Top 13 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
@databricks/eng-apps-devexas co-owner of.nextchanges/cli/apps-*.md, next to the existing apps rules in.github/CODEOWNERS.Why
Apps code (
cmd/apps/,libs/apps/,acceptance/apps/) is already co-owned by the apps team, but changelog fragments only match the*rule. As a result, any apps PR that adds a fragment needs an extra CLI maintainer approval for that one-line file. This mirrors the existing/.nextchanges/cli/docker-*.mdrule for Artifact Registry (#6894) and the dedicated.nextchanges/air/section (#6824). CLI maintainers stay on the rule and can still approve.Tests
./task checks(which includestools/validate_codeowners.py), the validator's doctests, andgit diff --checkall pass.This pull request and its description were written by Isaac.