Repository navigation
Fix generate-clijson for a blobless Universe checkout - #6929
Merged
Merged
Conversation
trap: the pinned go-task embedded shell (mvdan.cc/sh v3.13.1) only supports EXIT/ERR, so 'trap ... EXIT HUP INT TERM' aborts the recipe with "invalid signal specification" (exit 2). Use EXIT only. blobs: 'git clone --shared' does not propagate partial-clone/promisor config, so a blobless (filter=blob:none) UNIVERSE_DIR makes the temp checkout fail with "cannot read object" for every file blob not already in the shared object store. Mirror the source's promisor config onto the temp clone's origin so missing blobs are lazily fetched during checkout; no-op for a full checkout. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 9441592
Top 6 slowest tests (at least 2 minutes):
|
denik
approved these changes
Oct 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
Member
Author
|
popped from merge queue due to flaky ssh test https://github.com/databricks/cli/actions/runs/37613006327/job/112764757499 |
Collaborator
Integration test reportCommit: 921953a
469 interesting tests: 461 FAIL, 8 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human TL;DR: Fix generate-clijson task after I ran into issues during the latest SDK bump
Changes
Fix two pre-existing bugs in the
generate-clijsontask recipe that only surface when the task is actually run (it is excluded from CI's reproducible-generation check, so neither has been caught):go-taskembedded shell (mvdan.cc/shv3.13.1) only acceptsEXIT/ERRintrap, sotrap '...' EXIT HUP INT TERMaborts the recipe withtrap: HUP: invalid signal specification(exit 2). UseEXITonly.git clone --shareddoes not carry over partial-clone/promisor config, so whenUNIVERSE_DIRis a blobless (filter=blob:none) clone the temp checkout fails withcannot read objectfor every file blob not already in the shared object store. Mirror the source's promisor config onto the temp clone'sorigin(pointed at the upstream remote) so missing blobs are lazily fetched during checkout. No-op for a full clone.Why
Both were hit while running an SDK bump against a blobless
~/universepartial clone. Keepinggenerate-clijsonrunnable in that setup avoids a manual blob backfill before every bump.Tests
The
trap EXITchange was exercised end-to-end: with it applied,./task generate-clijsonruns through the genkit Bazel build and regenerates.codegen/cli.jsonon this setup, whereas the unpatched recipe aborts immediately withinvalid signal specification.The promisor-config change is not covered by an automated test. It mirrors the exact partial-clone config the Universe checkout itself uses (
remote.origin.promisor=truepluspartialclonefilter), so missing blobs resolve through the same lazy-fetch path; a full (non-partial)UNIVERSE_DIRis unaffected because the block only runs when the source has apartialclonefilter.This pull request and its description were written by Isaac.