Repository navigation
Conversation
Set returned 'cannot set key "k" on invalid' for nil map/pointer parents omitted via omitempty. Report the parent path as nil instead. Also avoids a panic when writing into a nil map. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 3935962
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting through a nil map/pointer/slice parent (omitted via omitempty) used to fail with
cannot set key "k" on invalid. It now sayscannot set m.k: parent m is nil. Missing parents are still not allocated. Also returns an error instead of panicking on a nil non-omitempty map.No goldens contained the old message.
This pull request and its description were written by Isaac.