Skip to content

Run generate-clijson cleanup via dedicated generate-clijson-post task #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janniklasrose merged 5 commits into from
Oct 12, 2026
Merged

Run generate-clijson cleanup via dedicated generate-clijson-post task #6924

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c50f374
Run generate-clijson cleanup via .codegen.json post_generate
janniklasrose Oct 5, 2026
531afec
Merge branch 'main' into janniklasrose/codegen-post-generate
janniklasrose Oct 6, 2026
51326a1
Merge remote-tracking branch 'origin/main' into janniklasrose/codegen…
janniklasrose Oct 9, 2026
950a39c
Move generate-clijson cleanup into a reusable generate-clijson-post task
janniklasrose Oct 9, 2026
97d5425
Merge remote-tracking branch 'origin/janniklasrose/codegen-post-gener…
janniklasrose Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,11 +887,22 @@ tasks:
--dir "{{.ROOT_DIR}}" \
--openapi-spec-file "$BUILD_DIR/universe/bazel-bin/openapi/all-internal.json" \
--openapi-spec-sha "$OPENAPI_SHA"
# The SDK-version consistency check runs here for fast feedback when
# generate-clijson is invoked manually. Cleanup of genkit's output is
# delegated to generate-clijson-post so the SDK bumper can reuse it.
- go test -timeout 240s -run TestConsistentDatabricksSdkVersion github.com/databricks/cli/internal/build
- task: generate-clijson-post

# Post-processing for genkit's `update-sdk` output, factored out of
# generate-clijson so the SDK bumper can run the same cleanup after its own
# update-sdk invocation.
generate-clijson-post:
desc: Clean up genkit update-sdk output (shared by generate-clijson and the SDK bumper)
cmds:
# genkit also writes .gitattributes, but that file is owned by
# generate-cligen (which derives it from .gitattributes.manual plus the
# rendered file list), so discard genkit's copy.
- git checkout -- .gitattributes
- go test -timeout 240s -run TestConsistentDatabricksSdkVersion github.com/databricks/cli/internal/build
- rm .github/workflows/next-changelog.yml
- mv tagging.py internal/genkit/tagging.py
- mv tagging.py.lock internal/genkit/tagging.py.lock
Expand Down
Loading