Skip to content

Turn provisioned-capacities -> pools - #6716

Open
vinchenzo-db wants to merge 2 commits into
mainfrom
air-pool-id
Open

vinchenzo-db wants to merge 2 commits into
mainfrom
air-pool-id

Conversation

@vinchenzo-db

Copy link
Copy Markdown
Contributor

Changes

Just a renaming to make commands shorter.

Why

Tests

Unit tests

vinchenzo-db and others added 2 commits September 15, 2026 22:27
Product renamed the concept to "GPU pool", so the run YAML field that selects a
reservation becomes compute.pool_id (hard rename, no back-compat alias).
priority_class now reads "requires pool_id". The value is still sent on the wire
as provisioned_capacity_id (the backend's name for a pool); only the
user-facing YAML field changed. Updated help text, validation messages, tests,
and the config-help / run-submit-deps acceptance goldens.

Co-authored-by: Isaac <no-reply@databricks.com>
Carry the user-facing pool rename through to the Go internals of the
submit path: provisionedCapacityID (variable and params) becomes poolID,
and injectReservationFields becomes injectPoolFields.

The on-wire key stays provisioned_capacity_id — that is the backend's
contract, so only the Go identifiers and the concept wording in comments
change, not any string sent to or parsed from the server.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/experimental/air/ - needs approval

4 files changed
Suggested: @ben-hansen-db
Also eligible: @maggiewang-db, @caroline-db, @apeforest, @bfontain, @panchalhp-db, @pardis-beikzadeh-db

/experimental/air/ - needs approval

6 files changed
Suggested: @ben-hansen-db
Also eligible: @maggiewang-db, @caroline-db, @apeforest, @bfontain, @panchalhp-db, @pardis-beikzadeh-db

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@vinchenzo-db
vinchenzo-db requested review from ben-hansen-db and maggiewang-db and removed request for maggiewang-db September 16, 2026 17:55

@ben-hansen-db ben-hansen-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PriorityClass *string `yaml:"priority_class" help:"Scheduling priority within the reservation: BEST_EFFORT (lowest, preemptable), NORMAL, or CRITICAL (highest). Requires provisioned_capacity_id."`
NumAccelerators int `yaml:"num_accelerators" help:"Total number of GPUs to allocate. Must be a positive multiple of the accelerator type's per-node GPU count. See https://docs.databricks.com/aws/en/machine-learning/ai-runtime/cli/yaml-config#reference for supported GPU types."`
AcceleratorType string `yaml:"accelerator_type" help:"Which accelerator to run on, e.g. GPU_1xA10. See https://docs.databricks.com/aws/en/machine-learning/ai-runtime/cli/yaml-config#reference for the current list of supported GPU types. Matched case-sensitively."`
PoolID *string `yaml:"pool_id" help:"GPU pool to run on, by id. A GPU pool is a pre-provisioned accelerator reservation; contact your Databricks account team to provision one. Must be 1-255 characters. List available pools with 'air list pools'."`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does air list pools exist yet?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists now!
#6595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants