acc: Replace find with find.py - #6714
Open
janniklasrose wants to merge 2 commits into
Open
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 2f2a5d4
Top 14 slowest tests (at least 2 minutes):
|
denik
reviewed
Sep 16, 2026
|
|
||
| If --expect N is provided, the number of matches must be N or error is printed. | ||
| If --include-dirs is provided, directories are matched and printed too (default: files only). | ||
| If --prune REGEX is provided, directories whose path matches REGEX are not descended into or printed. |
Contributor
There was a problem hiding this comment.
seems odd that --prune only prunes directories. Should it be called --prune-dirs in that case? or should it prune files as well?
| === Assert destroy leaves the bundle state dir clean: | ||
|
|
||
| >>> find .databricks -name terraform -prune -o -print | ||
| >>> find.py --include-dirs --prune terraform$ ^\.databricks(/|$) |
Contributor
There was a problem hiding this comment.
looking at this, I think find.py --dirs would be enough.
| === Direct-engine state is now in place; terraform state is backed up | ||
|
|
||
| >>> find .databricks/bundle -name resources.json -type f | ||
| >>> find.py ^\.databricks/bundle/.*resources\.json$ |
Contributor
There was a problem hiding this comment.
can we just teach it to accept exact directories as parameter like find?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all* usages of
findinacceptance/**/scriptwithfind.py*Except: https://github.com/databricks/cli/blob/main/acceptance/bundle/templates/pydabs/init-classic/script#L4 because it uses
-deleteand would make find.py mutating (read-only now).