Skip to content

Use github-native CODEOWNERS - #6709

Open
janniklasrose wants to merge 2 commits into
mainfrom
janniklasrose/maintainer-approval-blocking
Open

janniklasrose wants to merge 2 commits into
mainfrom
janniklasrose/maintainer-approval-blocking

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Sep 16, 2026

Copy link
Copy Markdown
Member

Changes

  1. Remove the maintainer-approval workflow
  2. Consolidate .github/OWNERS & .github/OWNERTEAMS into .github/CODEOWNERS
  3. To model "CLI maintainers can approve everything", include that team at the start of every entry
  4. Linter to make sure 3. is always true

Why

maintainer-approval check run has shown to be unreliable (requiring rebase despite getting sufficient approvals)

Tests

GitHub does not have a CODEOWNERS playground :-(

Comment thread .github/CODEOWNERS
@@ -0,0 +1,84 @@
# Maintainers can approve any PR. Keep them on every rule because GitHub uses

@janniklasrose janniklasrose Sep 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File equivalent to old OWNERS but team: replaced with @databricks/.

Created:

  • databricks/eng-deco-cli
  • databricks/eng-deco-dabs
  • databricks/eng-deco-ax
  • databricks/eng-deco-platform

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 907bc8f

Run: 35106323877

Env 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 275 15 8:31
💚​ aws windows 1 277 13 6:53
🔄​ azure linux 1 1 273 15 10:02
🔄​ azure windows 1 1 275 13 10:13
💚​ gcp linux 1 275 15 10:00
🔄​ gcp windows 1 1 276 13 8:55
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestSyncFullFileSync ✅​p ✅​p ✅​p 🔄​f ✅​p 🔄​f
🔄​ TestSyncIncrementalFileSync ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
Top 8 slowest tests (at least 2 minutes):
duration env testname
3:34 azure windows TestFilerWorkspaceFilesExtensionsReadDir
3:20 aws windows TestAccept
3:17 gcp windows TestAccept
3:12 azure windows TestAccept
2:33 gcp windows TestFilerWorkspaceFilesExtensionsReadDir
2:07 azure windows TestFilerWorkspaceFilesExtensionsDelete
2:03 aws windows TestFilerRecursiveDelete/workspace_files
2:00 gcp linux TestImportDirWithOverwriteFlag

Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERTEAMS
Comment thread .github/OWNERS
@janniklasrose
janniklasrose marked this pull request as ready for review September 16, 2026 14:07
@github-actions

Copy link
Copy Markdown
Contributor

Waiting for approval

Based on git history, these people are best suited to review:

  • @simonfaltum -- recent work in .github/workflows/, .github/, .github/scripts/
  • @pietern -- recent work in ./, tools/, .github/
  • @denik -- recent work in ./, tools/, .github/workflows/

Eligible reviewers: @andrewnester, @anton-107, @lennartkats-db, @rclarey, @renaudhartert-db, @rugpanov, @shreyas-goenka

Suggestions based on git history. See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants