Skip to content

Ignore local resource state when deployment history is enabled - #6686

Draft
shreyas-goenka wants to merge 5 commits into
databricks:mainfrom
shreyas-goenka:shreyas-goenka/dms-local-state-only
Draft

shreyas-goenka wants to merge 5 commits into
databricks:mainfrom
shreyas-goenka:shreyas-goenka/dms-local-state-only

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Changes

Use remote state for DMS without reading or writing local resources.json or its WAL. Legacy local DMS markers are excluded from selection and removed only after remote state is validated; marker/WAL pairs are preserved for reconciliation. Live remote DMS state still prevents switching modes.

Dashboard and Genie generate --resource now reject unsupported DMS mode before reading stale IDs. Explicit-ID generation and Terraform behavior remain supported.

Why

Cached state can survive destroy and block switching deployment history on or off. It can also send standalone resource generators to an old resource ID. Local resource state must remain exclusive to file-based deployments.

Tests

  • Two independent reviews completed; both reported issues and follow-up fixture findings are addressed.
  • Race-enabled unit tests pass for state management, direct state, bundle processing, and generators.
  • All 67 DMS/state/destroy/generate acceptance-test directories pass, including legacy-cache cleanup, WAL preservation, stale IDs, and Terraform compatibility.
  • Repository checks and lint pass.
  • Full acceptance had local environment failures reproduced with unchanged main. Hosted test/generated-file jobs are separately blocked during JFrog OIDC setup before testing.

This PR was written by Codex.

@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 6686
  • Commit SHA: f74057a0686d87b1b997c202e2d04c1508ffcb03

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant