Skip to content

[air] Apply permissions to direct-run jobs - #6653

Merged
caroline-db merged 2 commits into
mainfrom
air/direct-run-permissions
Sep 17, 2026
Merged

caroline-db merged 2 commits into
mainfrom
air/direct-run-permissions

Conversation

@caroline-db

@caroline-db caroline-db commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Apply configured additive permission grants to Jobs created by direct air run.
  • Do not update MLflow experiment ACLs; job-only log authorization is handled by a separate backend change.
  • Keep permission failures nonfatal after successful submission, while preserving validation and convert-to-DABs behavior.

Why

Direct AIR runs accepted permissions but did not apply them, while converted DABs already emitted Job permissions. Jobs ACLs govern orchestration data, including logs, while MLflow ACLs independently govern experiment data.

Tests

  • Added unit coverage for the outgoing Job permission request, principals, and levels.
  • Updated the AIR run-submit acceptance test to verify the Job lookup and permission PATCH and detect any MLflow requests.
  • Manually verified that a configured test group received explicit CAN_VIEW permission on the submitted Job.
  • Ran the focused permission unit and acceptance tests, ./task fmt, ./task checks, ./task lint, and ./task test.

This PR was written with Codex.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 03b16de

Run: 35113109253

Env 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 275 16 14:05
💚​ aws windows 1 277 14 9:35
🔄​ azure linux 1 1 273 16 10:16
💚​ azure windows 1 276 14 8:23
💚​ gcp linux 1 275 16 11:01
💚​ gcp windows 1 277 14 8:27
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestSyncFullFileSync ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
Top 16 slowest tests (at least 2 minutes):
duration env testname
4:13 azure windows TestAccept
3:38 aws windows TestAccept
3:25 gcp windows TestAccept
3:23 aws windows TestFilerWorkspaceFilesExtensionsRead
2:45 gcp windows TestLock
2:37 azure windows TestFilerRecursiveDelete/workspace_files_extensions
2:36 azure linux TestImportDirWithOverwriteFlag
2:31 azure linux TestFilerWorkspaceFilesExtensionsReadDir
2:31 gcp linux TestFilerReadDir/workspace_files
2:22 azure windows TestLock
2:15 aws linux TestFilerReadWrite/workspace_files
2:13 gcp linux TestFilerRecursiveDelete/workspace_files
2:07 azure windows TestFilerWorkspaceFilesExtensionsStat
2:04 gcp linux TestImportDir
2:02 aws windows TestFilerReadDir/workspace_files
2:02 gcp windows TestImportDir

@caroline-db
caroline-db marked this pull request as ready for review September 11, 2026 20:40

@maggiewang-db maggiewang-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi can you take a look at https://docs.google.com/document/d/1-ggJGjKrqU9iztORxvKdlHJlTFdA7lCgBOwOPoJP6a8/edit?usp=sharing (the recommended option section on top) ?

On a high level, the decision is:

  • Jobs ACLs govern orchestration data, including logs.
  • MLflow experiment ACLs govern experiment data such as metrics and configuration.

Sharing log access through CLI should therefore require only the job permission.

@caroline-db
caroline-db force-pushed the air/direct-run-permissions branch from e5e2694 to 03b16de Compare September 16, 2026 15:05
@caroline-db caroline-db changed the title [air] Apply permissions to direct-run jobs and MLflow experiments [air] Apply permissions to direct-run jobs Sep 16, 2026
@caroline-db
caroline-db added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 79edcc9 Sep 17, 2026
34 checks passed
@caroline-db
caroline-db deleted the air/direct-run-permissions branch September 17, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants