Fix model serving telemetry_config never converging and silently drop… - #6106
Draft
radakam wants to merge 2 commits into
Draft
Fix model serving telemetry_config never converging and silently drop…#6106radakam wants to merge 2 commits into
radakam wants to merge 2 commits into
Conversation
…ping updates telemetry_config is only carried by CreateServingEndpoint. The serving endpoints GET API never echoes it back, and no update API accepts it, so classify it as input_only for remote changes and no_update_api for local ones.
radakam
marked this pull request as ready for review
July 30, 2026 13:18
Contributor
Approval status: pending
|
radakam
marked this pull request as draft
July 30, 2026 13:41
Collaborator
Integration test reportCommit: 75c6765
11 interesting tests: 4 RECOVERED, 4 flaky, 3 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Classify model serving
telemetry_configinresources.ymlasinput_only(remote) andno_update_api(local).Why
The field only exists on
CreateServingEndpoint. GET never returns it, so remote reads back empty and everybundle planafter a deploy reported a perpetual update. No API accepts it either, soDoUpdatehad nothing to call and edits to it were silently dropped.Verified on dogfood: perpetual
1 to changebefore the fix,1 unchangedafter; changingsampling_fractionissued no mutating call.Tests
New
drift/telemetry_configacceptance test andmodel_serving_endpoint_telemetry_config.yml.tmplinvariant config.