integration/git: use static subtest names in TestFetchRepositoryInfo*#5375
Open
pietern wants to merge 1 commit into
Open
integration/git: use static subtest names in TestFetchRepositoryInfo*#5375pietern wants to merge 1 commit into
pietern wants to merge 1 commit into
Conversation
The TestFetchRepositoryInfo* tests passed runtime values into t.Run -- temporary workspace paths containing UUIDs and t.TempDir() paths -- so each subtest got a different name on every run. In aggregated test output this shows up as thousands of distinct one-off test names instead of a single stable entry. Replace the dynamic names with static ones (subdir, root, non-existent) by giving each table case an explicit name field. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
|
Commit: b59957d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestFetchRepositoryInfo*tests inintegration/libs/gitpassed runtime values intot.Run— temporary workspace paths containing UUIDs andt.TempDir()paths — so each subtest got a different name on every run. In aggregated test output this shows up as thousands of distinct one-off test names instead of a single stable entry.This replaces the dynamic names with static ones (
subdir,root,non-existent) by giving each table case an explicitnamefield.A sweep over every
t.Runcall in the repository found this to be the only place with this pattern.This pull request and its description were written by Isaac.