Open
Conversation
Collaborator
|
Commit: 530430e
14 interesting tests: 6 FAIL, 6 SKIP, 1 KNOWN, 1 flaky
Top 20 slowest tests (at least 2 minutes):
|
tanmay-db
commented
Feb 10, 2026
pietern
reviewed
Feb 10, 2026
Contributor
pietern
left a comment
There was a problem hiding this comment.
Please include the SDK version in the PR title.
| github.event_name == 'workflow_dispatch' || | ||
| github.repository == 'databricks/databricks-sdk-go' || | ||
| github.repository == 'databricks/databricks-sdk-py' || | ||
| github.repository == 'databricks/databricks-sdk-java' |
Contributor
There was a problem hiding this comment.
Please revert this. We don't want to auto-release.
Contributor
Author
There was a problem hiding this comment.
This was generated automatically, will revert
Contributor
Author
There was a problem hiding this comment.
Re-opening since we are discussing to keep this change as it's no-op cc: @renaudhartert-db
Contributor
There was a problem hiding this comment.
Ack, OK let's keep it. I see that this repo is excluded via the condition.
cc @simonfaltum
2269ce1 to
c7eefd2
Compare
pietern
approved these changes
Feb 17, 2026
| github.event_name == 'workflow_dispatch' || | ||
| github.repository == 'databricks/databricks-sdk-go' || | ||
| github.repository == 'databricks/databricks-sdk-py' || | ||
| github.repository == 'databricks/databricks-sdk-java' |
Contributor
There was a problem hiding this comment.
Ack, OK let's keep it. I see that this repo is excluded via the condition.
cc @simonfaltum
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Updating Go SDK to v0.106.0 2. Refactoring Go SDK Config Workspace`Id` to Workspace`ID` Note: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those would be done in separate PR to keep this PR specific to Go SDK bump. The other PR would be created once this is merged. ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use `ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
) ## Changes <!-- Brief summary of your changes that is easy to understand --> - Rename WorkspaceId to WorkspaceID across CLI-owned struct fields, parameters, and local variables to follow idiomatic Go naming conventions (acronyms should be all caps) - Fix a pre-existing typo in runlocal.NewConfig parameter name (workpaceId → workspaceID, which was missing an r in "workspace") - This is a follow-up to #4486 which renamed the upstream SDK field; this PR covers the CLI's own types: AuthArguments, Profile, Workspace, and runlocal.Config ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use Workspace`ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Idto WorkspaceIDNote: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those are done in: #4532
Why
Best practice to use
IDTests
Existing tests