Skip to content

feat(appkit): add global uncaughtException/unhandledRejection handlers #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarioCadenas wants to merge 3 commits into from
Closed

feat(appkit): add global uncaughtException/unhandledRejection handlers #448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee5a98
feat(appkit): add global uncaughtException/unhandledRejection handlers
MarioCadenas Jun 13, 2026
303982d
refactor(appkit): derive process-handler install latch from started-s…
MarioCadenas Jun 13, 2026
5e75cc5
refactor(appkit): keep process-handler guard simple
MarioCadenas Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions packages/appkit/src/plugins/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ dotenv.config({ path: path.resolve(process.cwd(), "./.env") });

const logger = createLogger("server");

// Registered once per process; repeated start() calls (e.g. in tests) must not
// stack handlers on the shared `process`.
let processHandlersRegistered = false;

/** Dev-only: try `requested` then consecutive ports (see `get-port` `portNumbers`). */
const devListenPortSpan = 100;

Expand Down Expand Up @@ -160,8 +164,7 @@ export class ServerPlugin extends Plugin {
// attach server to remote tunnel controller
this.remoteTunnelController.setServer(server);

process.on("SIGTERM", () => this._gracefulShutdown());
process.on("SIGINT", () => this._gracefulShutdown());
this._registerProcessHandlers();

if (process.env.NODE_ENV === "development") {
const allRoutes = getRoutes(this.serverApplication._router.stack);
Expand Down Expand Up @@ -398,7 +401,22 @@ export class ServerPlugin extends Plugin {
}
}

private async _gracefulShutdown() {
private _registerProcessHandlers() {
if (processHandlersRegistered) return;
processHandlersRegistered = true;

process.on("SIGTERM", () => this._gracefulShutdown());
process.on("SIGINT", () => this._gracefulShutdown());
process.on("uncaughtException", (error: Error, origin) => {
logger.error("Uncaught exception (%s), shutting down: %O", origin, error);
this._gracefulShutdown(1);
});
process.on("unhandledRejection", (reason) => {
logger.error("Unhandled promise rejection: %O", reason);
});
}

private async _gracefulShutdown(exitCode = 0) {
logger.info("Starting graceful shutdown...");

if (this.viteDevServer) {
Expand Down Expand Up @@ -433,7 +451,7 @@ export class ServerPlugin extends Plugin {
if (this.server) {
this.server.close(() => {
logger.debug("Server closed gracefully");
process.exit(0);
process.exit(exitCode);
});

// 3. timeout to force shutdown after 15 seconds
Expand All @@ -442,7 +460,7 @@ export class ServerPlugin extends Plugin {
process.exit(1);
}, 15000);
} else {
process.exit(0);
process.exit(exitCode);
}
}

Expand Down
Loading