Fix metric view YAML comment field ordering (#402)#445
Open
jacksandom wants to merge 1 commit intomainfrom
Open
Fix metric view YAML comment field ordering (#402)#445jacksandom wants to merge 1 commit intomainfrom
jacksandom wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
METRIC_VIEW_INVALID_VIEW_DEFINITIONerror when creating metric views with acommentfieldcommentandsourceordering in YAML generation and all documentation/test examplesCloses #402
Problem
_build_yaml_block()generated YAML withcommentbeforesource, but the Databricks parser expectssourceat index 1 (right afterversion). Any metric view created with a comment would fail with:METRIC_VIEW_INVALID_VIEW_DEFINITION: Missing required creator property 'source' (index 1)Changes
databricks-tools-core/.../unity_catalog/metric_views.pysourcebeforecommentin_build_yaml_block()databricks-skills/databricks-metric-views/SKILL.mddatabricks-skills/databricks-metric-views/patterns.md.test/skills/databricks-metric-views/ground_truth.yamlTest plan
versionthensourcethencommentordering