refactor(sql): separate aggregate registration and reuse in binder#19579
Merged
forsaken628 merged 20 commits intodatabendlabs:mainfrom Mar 27, 2026
Merged
refactor(sql): separate aggregate registration and reuse in binder#19579forsaken628 merged 20 commits intodatabendlabs:mainfrom
forsaken628 merged 20 commits intodatabendlabs:mainfrom
Conversation
github-actions
Bot
added
the
pr-refactor
forsaken628
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4e00ba538
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
b41sh
reviewed
Mar 26, 2026
b41sh
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
AggregateInforegistry so builtin aggregates, UDAFs, group items, and grouping metadata follow the same binder path.WINDOW,QUALIFY,ORDER BY, andProjectSetby preventing late aggregate creation, fixing alias visibility, and making aggregate arguments resolve against the right scope.ProjectSet, grouped alias reuse, named window inheritance checks, andGROUPING SETS/CUBE/ROLLUP/grouping()rewriting.BindContextand expand golden/integration coverage for binder, window, identifier, and optimizer regressions.Tests
Type of change
This change is