ENH: add a no x64 device#224
Open
ev-br wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "no_x64" device which only supports 32-bit ints and floats.
This device mimics the JAX's default (and the name follows the JAX
jax_enable_x64flag name).As discussed and requested in the Array API meeting on Jul 09.
For convenience, this PR is on top of gh-221, so only the last commit, c180b0e, is relevant.
Since we're getting a 2.6.1 release "quickly", and a
no_float64device was added in 2.6, I'm thinking about sneaking this new device into 2.6.1, too. Thoughts?