Repository navigation
fix(reinforcement): preserve FaaS business errors and request context - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_idand response context through layer, load, and tuning failures while keeping existing numeric SDK error codes.ResponseFCrepr.Scope
This PR merges
dev/v2.1-2intomainand contains:cb6e3668: SDK business-error handling and request-context preservation.7e5042be: test-only CI fixes for formatting and the legacy RL CLI help assertion; no SDK behavior changes.It improves SDK error handling and diagnostics; it does not change gateway URLs, request headers, or region parameters, and does not fix the server-side
FaaS layer not found for region nullissue. A fresh curl-first probe reproduced the same business error as the earlier SDK-first probe.Local Validation
python -m pytest -q tests/legacy_1x/unit/test_cli_main.py tests/test_agentic_rl_fc_errors.py tests/legacy_1x/unit/test_agentic_rl_layer_status.py— 78 passed.python -m pytest -q tests/legacy_1x— 1122 passed, 42 skipped.pre-commit run --all-files— all applicable hooks passed.0.29.0) and Click (8.5.1); the previous help-output assertion was reproduced as failing before the fix.