fix: disable key-wallet default features in rpc-json#589
fix: disable key-wallet default features in rpc-json#589xdustinface wants to merge 4 commits intov0.42-devfrom
key-wallet default features in rpc-json#589Conversation
`generate_using_rng` and `generate_with_seed` were only used in tests but exposed as public API requiring `rand` at compile time. Move them to `mod tests` as private helpers and drop `rand` from the crate's default features. `rand` remains as optional dep for `bip38` and is added as a dev-dependency for test use.
These were only enabled via default features, so `--no-default-features` would break compilation because `bip39` requires its `std` feature for `parse_in` and `to_seed`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #589 +/- ##
=============================================
- Coverage 67.40% 67.38% -0.02%
=============================================
Files 318 318
Lines 67020 67020
=============================================
- Hits 45175 45164 -11
- Misses 21845 21856 +11
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
No description provided.