fix: clean up key-wallet feature flags after no-std removal#588
Merged
xdustinface merged 2 commits intov0.42-devfrom Mar 27, 2026
Merged
fix: clean up key-wallet feature flags after no-std removal#588xdustinface merged 2 commits intov0.42-devfrom
key-wallet feature flags after no-std removal#588xdustinface merged 2 commits intov0.42-devfrom
Conversation
`generate_using_rng` and `generate_with_seed` were only used in tests but exposed as public API requiring `rand` at compile time. Move them to `mod tests` as private helpers and drop `rand` from the crate's default features. `rand` remains as optional dep for `bip38` and is added as a dev-dependency for test use.
These were only enabled via default features, so `--no-default-features` would break compilation because `bip39` requires its `std` feature for `parse_in` and `to_seed`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #588 +/- ##
=============================================
+ Coverage 67.21% 67.37% +0.15%
=============================================
Files 318 318
Lines 67025 67020 -5
=============================================
+ Hits 45052 45153 +101
+ Misses 21973 21867 -106
|
QuantumExplorer
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_using_rngandgenerate_with_seedfrom public API, moverandfrom optional dependency todev-dependencybip39/stdandsecp256k1/stdunconditional sokey-walletcompiles with--no-default-featuresFollow-up to #518.