update LICENSE info - #262
Conversation
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Documentation-only PR that reorders the README copyright lines and removes the Bitcore trademark sentence. Verified against the diff: the previous lines ended with two trailing spaces (forcing Markdown hard breaks); the new lines do not, so the three copyright notices will render as a single run-on paragraph on GitHub/npm. LICENSE file is untouched and remains out of sync, but that predates the PR.
💬 1 nitpick(s)
Out-of-scope follow-up suggestions (1)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- LICENSE copyright years and entities are out of sync with README — The checked-in
LICENSEstill readsCopyright (c) 2017-2018 Dash Core Group, Inc.and does not list The Dash Foundation, Inc., while README now reads2017-2020 Dash Core Group, Inc.and lists The Dash Foundation. The divergence predates this PR (LICENSE is not modified here despite the commit message), and the PR's stated scope is the README attribution footer only, so this is not a blocker — but the two files should be reconciled separately.- Follow-up: Open a separate maintainer-requested PR to reconcile
LICENSEcopyright years and listed entities with the README attribution (or vice versa).
- Follow-up: Open a separate maintainer-requested PR to reconcile
| Copyright 2017-2020 Dash Core Group, Inc. | ||
| Copyright 2016-2017 The Dash Foundation, Inc. | ||
| Copyright 2013-2017 BitPay, Inc. |
There was a problem hiding this comment.
💬 Nitpick: Copyright lines lose hard line breaks and render as one run-on paragraph
Verified against the diff: the removed lines ended with two trailing spaces (GFM hard-break markers), and the replacement lines do not. In GitHub-Flavored Markdown, consecutive non-blank lines inside the same paragraph are joined with a single space on render unless each non-final line ends with two trailing spaces, a backslash, or <br>. As-is, the three copyright notices will display as one wrapped paragraph (Copyright 2017-2020 Dash Core Group, Inc. Copyright 2016-2017 The Dash Foundation, Inc. Copyright 2013-2017 BitPay, Inc.) instead of three separate lines as before. Restoring the two trailing spaces on the first two lines preserves the prior rendering.
| Copyright 2017-2020 Dash Core Group, Inc. | |
| Copyright 2016-2017 The Dash Foundation, Inc. | |
| Copyright 2013-2017 BitPay, Inc. | |
| Copyright 2017-2020 Dash Core Group, Inc. | |
| Copyright 2016-2017 The Dash Foundation, Inc. | |
| Copyright 2013-2017 BitPay, Inc. |
source: ['claude']
|
✅ Final review complete — Phase 1 only — no blockers (commit 358a09f) · triage: trivial |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final review — Phase 1 only (trivial change)
The README-only change correctly reorders the copyright notices and removes the obsolete trademark sentence without altering the LICENSE file. The sole issue is an extra blank line introduced at the end of README.md, which git diff --check reports as a whitespace error.
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-5.6-sol (agent: sol-verifier, role: final-verifier)
Review provenance
- Triage:
trivialbygpt-6-astra(effort low) — The change only reorders copyright notices and removes a trademark statement in README.md, without modifying the license file or any executable behavior. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Fresh verifier:
gpt-5.6-sol— final-verifier; agentsol-verifier - Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
💬 1 nitpick(s)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `README.md`:
- [NITPICK] README.md:152-155: Remove the extra blank line at the end of README.md
The file now ends with two newline bytes instead of the repository's previous single final newline, and `git diff --check master...HEAD` reports `README.md:155: new blank line at EOF.` This whitespace-only addition is unrelated to the intended license-text update and should be removed.
| Copyright 2017-2020 Dash Core Group, Inc. | ||
| Copyright 2016-2017 The Dash Foundation, Inc. | ||
| Copyright 2013-2017 BitPay, Inc. | ||
|
|
There was a problem hiding this comment.
💬 Nitpick: Remove the extra blank line at the end of README.md
The file now ends with two newline bytes instead of the repository's previous single final newline, and git diff --check master...HEAD reports README.md:155: new blank line at EOF. This whitespace-only addition is unrelated to the intended license-text update and should be removed.
| Copyright 2017-2020 Dash Core Group, Inc. | |
| Copyright 2016-2017 The Dash Foundation, Inc. | |
| Copyright 2013-2017 BitPay, Inc. | |
| Copyright 2017-2020 Dash Core Group, Inc. | |
| Copyright 2016-2017 The Dash Foundation, Inc. | |
| Copyright 2013-2017 BitPay, Inc. |
source: ['codex']
Dash is the current maintainer of this software, Dash comes first.
We don't use the Bitpay / Bitcore trademarks, we don't need to mention them or draw additional attention to them.