Skip to content

update LICENSE info - #262

Open
coolaj86 wants to merge 1 commit into
dashpay:masterfrom
coolaj86:patch-2
Open

update LICENSE info#262
coolaj86 wants to merge 1 commit into
dashpay:masterfrom
coolaj86:patch-2

Conversation

@coolaj86

Copy link
Copy Markdown

Dash is the current maintainer of this software, Dash comes first.

We don't use the Bitpay / Bitcore trademarks, we don't need to mention them or draw additional attention to them.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Documentation-only PR that reorders the README copyright lines and removes the Bitcore trademark sentence. Verified against the diff: the previous lines ended with two trailing spaces (forcing Markdown hard breaks); the new lines do not, so the three copyright notices will render as a single run-on paragraph on GitHub/npm. LICENSE file is untouched and remains out of sync, but that predates the PR.

💬 1 nitpick(s)

Out-of-scope follow-up suggestions (1)

These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.

  • LICENSE copyright years and entities are out of sync with README — The checked-in LICENSE still reads Copyright (c) 2017-2018 Dash Core Group, Inc. and does not list The Dash Foundation, Inc., while README now reads 2017-2020 Dash Core Group, Inc. and lists The Dash Foundation. The divergence predates this PR (LICENSE is not modified here despite the commit message), and the PR's stated scope is the README attribution footer only, so this is not a blocker — but the two files should be reconciled separately.
    • Follow-up: Open a separate maintainer-requested PR to reconcile LICENSE copyright years and listed entities with the README attribution (or vice versa).

Comment thread README.md
Comment on lines 152 to +154
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Copyright lines lose hard line breaks and render as one run-on paragraph

Verified against the diff: the removed lines ended with two trailing spaces (GFM hard-break markers), and the replacement lines do not. In GitHub-Flavored Markdown, consecutive non-blank lines inside the same paragraph are joined with a single space on render unless each non-final line ends with two trailing spaces, a backslash, or <br>. As-is, the three copyright notices will display as one wrapped paragraph (Copyright 2017-2020 Dash Core Group, Inc. Copyright 2016-2017 The Dash Foundation, Inc. Copyright 2013-2017 BitPay, Inc.) instead of three separate lines as before. Restoring the two trailing spaces on the first two lines preserves the prior rendering.

Suggested change
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.

source: ['claude']

@thepastaclaw

thepastaclaw commented Jun 7, 2026

Copy link
Copy Markdown

✅ Final review complete — Phase 1 only — no blockers (commit 358a09f) · triage: trivial

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review — Phase 1 only (trivial change)

The README-only change correctly reorders the copyright notices and removes the obsolete trademark sentence without altering the LICENSE file. The sole issue is an extra blank line introduced at the end of README.md, which git diff --check reports as a whitespace error.

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-5.6-sol (agent: sol-verifier, role: final-verifier)

Review provenance

  • Triage: trivial by gpt-6-astra (effort low) — The change only reorders copyright notices and removes a trademark statement in README.md, without modifying the license file or any executable behavior.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Fresh verifier: gpt-5.6-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves

💬 1 nitpick(s)

🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `README.md`:
- [NITPICK] README.md:152-155: Remove the extra blank line at the end of README.md
  The file now ends with two newline bytes instead of the repository's previous single final newline, and `git diff --check master...HEAD` reports `README.md:155: new blank line at EOF.` This whitespace-only addition is unrelated to the intended license-text update and should be removed.

Comment thread README.md
Comment on lines 152 to +155
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Remove the extra blank line at the end of README.md

The file now ends with two newline bytes instead of the repository's previous single final newline, and git diff --check master...HEAD reports README.md:155: new blank line at EOF. This whitespace-only addition is unrelated to the intended license-text update and should be removed.

Suggested change
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.
Copyright 2017-2020 Dash Core Group, Inc.
Copyright 2016-2017 The Dash Foundation, Inc.
Copyright 2013-2017 BitPay, Inc.

source: ['codex']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants