fix: stabilize par help text in manpages#7394
Conversation
|
@coderabbitai review |
|
✅ Review complete (commit 4e5cc4b) |
✅ Action performedReview finished.
|
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe help text for Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Verified PR #7394 at exact head SHA 4e5cc4b. The diff is limited to stabilizing the -par and -parbls help/manpage text, the generated manpage entries match src/init.cpp, and the runtime parsing still supports auto, negative values, and max clamping as documented.
Note: posted as a COMMENT review because GitHub does not allow approving my own PR.
fix: stabilize par help text in manpages
Issue being fixed or feature implemented
Regenerating manpages currently records the local machine's CPU count in the
-parand-parblshelp text. That makes otherwise unrelated releasemanpage regeneration change those entries depending on which machine generated
the pages.
What was done?
Updated the
-parand-parblshelp text to avoid printing the dynamic lowerbound derived from
GetNumCores().Runtime behavior is unchanged: negative values still mean "leave that many
cores free",
0still auto-detects, and the existing max/default values remaindocumented. The checked-in
dashdanddash-qtmanpages were updated to matchthe new stable generated text.
How Has This Been Tested?
Tested on macOS arm64:
git diff --check python3 -m py_compile contrib/devtools/gen-manpages.py rg -n -e '\\fB\\-[0-9]+\\fR to' doc/man/dashd.1 doc/man/dash-qt.1The grep command returned no matches, confirming the affected generated
manpages no longer contain a CPU-count-specific lower bound.
Also ran a pre-PR code review gate against the exact worktree diff:
Note: this worktree did not have configured Dash Core build artifacts and
help2manis not installed locally, so I did not rerun full manpage generationfrom rebuilt binaries here. The manpage edits mirror the changed
src/init.cpphelp text.
Breaking Changes
None.
Checklist
code-owners and collaborators only)