Test cases for StoreHDF5 read and write for issue #692#699
Open
anindex wants to merge 5 commits intodash-project:developmentfrom
Open
Test cases for StoreHDF5 read and write for issue #692#699anindex wants to merge 5 commits intodash-project:developmentfrom
anindex wants to merge 5 commits intodash-project:developmentfrom
Conversation
… and unsigned type
Contributor
Author
|
I met some weird internal errors in HDF5 library when setting Otherwise, all test cases pass successfully. |
Codecov Report
@@ Coverage Diff @@
## development #699 +/- ##
===============================================
+ Coverage 83.65% 84.18% +0.53%
===============================================
Files 336 336
Lines 24968 25072 +104
Branches 11354 11411 +57
===============================================
+ Hits 20887 21108 +221
- Misses 3692 3693 +1
+ Partials 389 271 -118
|
Contributor
Author
|
I have worked around the internal HDF5 errors of 1D As mentioned before, StoreHDF::write popups internal HDF5 library error if I use this initialization: |
Member
Which error exactly do you see there? |
Contributor
Author
|
The error I posted in the previous comment and it is also the cause for CI failing last time we saw it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes test cases for StoreHDF5::read and StoreHDF5::write with dash::Matrix. Test cases consist of 1D and 2D matrices with the default and unsigned index type.