WIP: Make more Teams const

[bertwesarg]

Hodgepodge to make the Team const. Does not build yet.

[devreal]

The LoadBalancePattern uses TeamLocality and the build fails because it's not const there:

cd /root/project/build-ci/20200302-153606--uuid-f5bf5f2c/clang/Release/build/dash && /usr/bin/clang++-5.0   -I/root/project/dash/include -I/root/project/dash/src -I/root/project/dart-if/include -I/opt/mpich/include -I/opt/papi/include -I/opt/phdf5/include -I/root/project/vendor/googletest/googletest/include  -mtune=native -march=native -mfpmath=sse -fopenmp=libomp   -O3 -DNDEBUG  -Ofast -DDASH_RELEASE -fPIC    -DDASH_MPI_IMPL_ID='mpich' -DMPICH_SKIP_MPICXX  -DDASH -DDASH_ENABLE_DEFAULT_INDEX_TYPE_LONG -DDASH_ENABLE_TEST_LOGGING -DDASH_ENABLE_PAPI -DDASH_ENABLE_HWLOC -DDASH_ENABLE_NUMA -DDASH_ENABLE_HDF5 -DDASH_HAVE_STD_TRIVIALLY_COPYABLE -DDASH_ENV_HOST_SYSTEM_ID='default' -fopenmp=libomp -std=gnu++14 -o CMakeFiles/dash-mpi.dir/src/Init.cc.o -c /root/project/dash/src/Init.cc
In file included from /root/project/dash/src/Init.cc:5:
In file included from /root/project/dash/include/dash/Shared.h:13:
In file included from /root/project/dash/include/dash/iterator/GlobIter.h:6:
In file included from /root/project/dash/include/dash/Pattern.h:625:
/root/project/dash/include/dash/pattern/LoadBalancePattern.h:320:5: error: cannot initialize a member subobject of type 'dash::Team *' with an rvalue of type 'const dash::Team *'
    _team(&team_loc.team()),
    ^     ~~~~~~~~~~~~~~~~
1 error generated.
dash/CMakeFiles/dash-mpi.dir/build.make:110: recipe for target 'dash/CMakeFiles/dash-mpi.dir/src/Init.cc.o' failed

[devreal]

On a more general note, I'm all in favor of making Team const where possible but that seems to be a bigger adventure :/

[bertwesarg]

BTW, I'm still not able to look into the build logs from circle CI. I'm just do not see the uploaded build.log artifact. If there is anything others need to do, to get me there, then please do so. If I need to do anything then please tell me. Thanks.

[devreal]

@bertwesarg I just added you to the developers group. You have to be logged in on CircleCI (with your Github credentials) to see the artifacts. Can you try again?