Fix local_size() in some patterns and improve short-cut detection#655
Open
devreal wants to merge 2 commits intodevelopmentfrom
Open
Fix local_size() in some patterns and improve short-cut detection#655devreal wants to merge 2 commits intodevelopmentfrom
devreal wants to merge 2 commits intodevelopmentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## development #655 +/- ##
===============================================
+ Coverage 85.06% 85.13% +0.07%
===============================================
Files 336 336
Lines 24954 24984 +30
Branches 11803 11358 -445
===============================================
+ Hits 21226 21271 +45
+ Misses 3693 3691 -2
+ Partials 35 22 -13
|
Member
|
Solves the infinite loop in #653, but not the example fully. |
Member
Author
|
Please review |
Member
|
I'll pass. Cannot add something to this. If it works, than got ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653