You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes two issues with MatrixReflbegin/lend:
Fixed compiler error
Fixed lend() in LocalMatrixRef (and thus MatrixRef) to not return a nullptr but a pointer past the end of the range (GlobViewIter::local() returns nullptr if pointing beyond the current unit)
@fuchsto I'm giving up here as it is not clear to me anymore which are global and local block coordinates and indexes. Also, I suspect that there are fixes lingering around in your branches. I'd appreciate a timely merge or a quick fix as the broken lbegin() on blocks is a road block for me right now.
@devreal Sorry, I don't get it: what's the original issue? Is the use case covered in the unit test you added?
I found a bug related to #418 and will fix it in a separate PR, not sure if it helps your use case.
This PR was my attempt to fix Matrix::lbegin a month after I reported the issue in #418 but I got lost in the usage of CartesianIndexSpace (does it hold local or global indexes? pretty confusing for me) My original use case should be covered by the test case I added here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with
MatrixReflbegin/lend:lend()inLocalMatrixRef(and thusMatrixRef) to not return anullptrbut a pointer past the end of the range (GlobViewIter::local()returnsnullptrif pointing beyond the current unit)