Repository navigation
ci: replace fragile secret-scan ignore with a placeholder allowlist - #31
Merged
Merged
Conversation
The old ignore entry named a pre-squash commit hash, so every squash merge re-triggered the finding. A .gitleaks.toml that extends the default rules and allows only the YOUR_API_KEY placeholder does not depend on commit hashes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The latest commit on main shows a red CI X: the secret scan flags the fake token in the docs-pipeline sample curl command, because the ignore entry named a pre-squash commit hash. Cold review 2, finding H1. Ticket: JBSR-099.
Changes
.gitleaksignore..gitleaks.toml: extends the default rules and allows only the placeholder textYOUR_API_KEY, so squash merges no longer break it.🤖 Generated with Claude Code
https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6