Repository navigation
fix(docs-pipeline): make it run from a fresh clone and remove private setup - #30
Merged
Merged
Conversation
… setup Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
…lity skill readme Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
An independent cold review found that the docs-pipeline, the first example in this repo, stopped on a fresh clone: stage 3b and stage 4c looked for knowledge files that were not shipped, stage 0 needed a private tooling repo, and there was no way to install the skills. Its style guides also read like they came from a payments company. This fixes findings H1, H2, H3 and M7 and the low findings that touch the docs-pipeline or the readability skill. Ticket: JBSR-099.
Changes
_knowledge/style-guides/general/style-guide_general.md, and the other style passes read from./_knowledge/too..cursorlinks. It copies_knowledge/into each workspace, ships its ownworkspace-gitignore.template, and treats{SHARED_CONFIG_DIR}and{NOTES_DIR}as optional: unset means the step is skipped. The audit's optional schema and diagram tool follow the same rule, and the docs repo steps in stage 4c skip with a note instead of stopping. The personal-habit line is now a neutral sentence.SKILL.mdfolder per skill, 17 in all, with the pipeline path filled in), a way to check they registered, and a smoke test on a new sample doc,sample/acme-orders-cancellations.md. The leftover Downloads grep is fixed.skills/docs-readability-checkwith a prompt block (L5), unrendered template links wrapped (L7), a reserved example domain (L8), saved prompt run records (L11), and the 'Understand and teach' prompt now asks what the person does between stages (L12).tests/check_pipeline.pyis an offline check (26 problems on the old main, none now).tests/smoke-test-run.mdholds real output from a fresh clone: install, stage 0, stage 3b and stage 4c, plus stages 1, 3c, 3d and 3e. Prompts were re-run on Sonnet and Haiku, with the answers intests/prompt-runs/.pipelines/docs-pipeline/andskills/docs-readability-check/. Nothing else changed.🤖 Generated with Claude Code
https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6