Repository navigation
fix(job-assessment): use unrelated fictional pay numbers and report bad findings cleanly - #28
Merged
Conversation
…ad findings cleanly Robin Sample's pay figures and the three posting ranges now use different round fictional values with the same ordering and bands, so every score and verdict is unchanged. check_findings.py now reports list items or sections of the wrong shape as normal problem lines instead of a traceback. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Two follow-ups from the WP-9 "still open" list, tracked in JBSR-099. The fictional persona's pay numbers should not match any real person's, and check_findings.py crashed with a Python traceback when a culture list held plain strings instead of objects.
Changes
Review notes
Offline suite: 539 passed, 2 skipped (was 527 passed, 2 skipped; the 12 new tests are the difference).
🤖 Generated with Claude Code
https://claude.ai/code/session_01XV3Ggh86cf2xwUyz28XaN6