chore(context): reconcile .project/ reader with CNCF upstream (1.3.0 -> 1.4.0) - #398
Merged
mlieberman85 merged 1 commit intoAug 26, 2026
Conversation
…-> 1.4.0) Upstream added a `Managed *bool` field to the `Team` struct in `utilities/dot-project/types.go` (nil defaults to managed; false excludes the team from CNCF resource automation). Darnit does not consume this attribute today, so the reader picks it up via the existing unknown-field catch-all in `_parse_maintainer_teams` into `MaintainerTeam._extra["managed"]` (NEW-IGNORED classification per feature 030 Q1: parse-only scope). No new dataclass, no new parsing helper, no new attribute on `MaintainerTeam`. Just the version + reconciliation-history bump plus the tracked-hash refresh so `test_upstream_spec_unchanged` stops firing on every open PR. Also updates the pinned version-check test to the new value; the test name previously referenced the specific 1.3.0 milestone. Closes darnitdevorg#397. Reconcile SHA: cncf/automation@e9adbac (was cncf/automation@afa3d17 via bd7fec94).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconciles darnit's
.project/reader with the current CNCF upstreamper the runbook at
specs/030-dot-project-spec-sync/quickstart.md.Upstream (
cncf/automation@e9adbac) added a single new field:```go
type Team struct {
Name string `json:"name" yaml:"name"`
Members []string `json:"members" yaml:"members"`
Managed *bool `json:"managed,omitempty" yaml:"managed,omitempty"`
}
func (t Team) IsManaged() bool {
return t.Managed == nil || *t.Managed
}
```
Nil defaults to managed; false excludes the team from CNCF resource
automation (handle verification, mailing lists, service desk, Copilot
seats). Darnit does not consume this attribute today.
Classification
teams[*].managedis NEW-IGNORED per feature 030 Q1 (parse-onlyscope). The reader's existing unknown-field catch-all in
_parse_maintainer_teamsputs it inMaintainerTeam._extra["managed"]automatically. No dataclass, parsing helper, or new attribute
needed -- when a control eventually wants to consume it, that's a
separate feature.
Changes
.github/dot-project-spec-hash.txt:afa3d17...->e9adbac....packages/darnit/src/darnit/context/dot_project.py:DOT_PROJECT_SPEC_VERSION1.3.0 -> 1.4.0, plus the reconciliation-history docstring + inline note.
tests/darnit/context/test_dot_project.py: pinned version-checktest renamed from
test_spec_version_bumped_to_1_3_0to_1_4_0.Test plan
pytest tests/darnit/context/test_dot_project_upstream.py -vpasses (was blocking every open PR).
pytest tests/darnit/context/test_full_field_coverage.pypasses without golden update (NEW-IGNORED doesn't change reader
output shape).
pytest tests/darnit/ -q-> 1808 pass,8 skip, 0 fail (after the pinned-version test rename).
Not this PR
managedas aMaintainerTeamattribute (Q1:parse-only).
DotProjectWriter. Writer stays scalar-only.packages/darnit-baseline/. Per plan §ProjectStructure this is core-only.
Closes #397.