fix module-border-settings not saving - #22109
Merged
Merged
Conversation
TurboGit
approved these changes
Sep 1, 2026
TurboGit
left a comment
TurboGit
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks for fixing.
TurboGit
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new settings general/focused module border + expanded module border were not being saved across launches of darktable.
Cause: themes/focused-module-border and themes/expanded-module-border are stored as combobox indices via dt_conf_set_int()/dt_conf_get_int(), but darktableconfig.xml.in declared them as bool.
_sanitize_confgen() treats any DT_BOOL-typed value that isn't literally "true"/"false" as garbage and resets it to the schema default when darktablerc is read on startup. Since the persisted value is always a plain index ("0"–"6"), both settings silently reverted to their default (disabled) on every restart, even though they applied correctly for the rest of the running session.
Also fixes a related mismatch: the code reads/writes themes/accent-color, while the schema registered themes/colored-accent under that same feature. Renamed the schema entry to match the code.
No release note as the feature isn't present in 5.6.1.
Co-Created with Claude Opus 5