Invalidate watermark cachelines for tag/metadata change - #22103
Open
jenshannoschwalm wants to merge 1 commit into
Open
Invalidate watermark cachelines for tag/metadata change#22103jenshannoschwalm wants to merge 1 commit into
jenshannoschwalm wants to merge 1 commit into
Conversation
jenshannoschwalm
added
bugfix
Collaborator
Author
|
Integration tests are fine, as the issue is very unlikely to happen i think there is no need for a release note. |
TurboGit
requested changes
Sep 1, 2026
TurboGit
left a comment
TurboGit
left a comment
Member
There was a problem hiding this comment.
We can still do better:
- Open an image in darkroom
- Add a watermark with tags -
metadata-template (svg). - Add a tag, it gets displayed in the watermark
- Go to lighttable
- Add a tag
- Open the same image in darkroom, see that the new tag is not attached
Member
|
BTW, this one needs a release notes. |
Collaborator
Author
Right, didn't test. |
As reported a metadata or tag change leaves an invalid cacheline, the suggested fix is good and the performance penalty is neglectable as those changes are rare and the module has a high iop_order. While being in lighttable view we don't have the iop_order ready so we simply clear the darkroom pipe caches for the next run. Fixes darktable-org#22069
jenshannoschwalm
force-pushed
the
fix_22069
branch
from
September 1, 2026 18:53
93774b3 to
82d45d6
Compare
Collaborator
Author
|
@TurboGit added a release note, hooked in thumbtable tag & metadata signals fixing the reported issue. |
Member
|
@jenshannoschwalm : We may also need to invalidate the cached mipmaps as the thumbs do no get refreshed and does not correspond to what we see on darkroom. EDIT: maybe just invalidate the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported a metadata or tag change leaves an invalid cacheline, the suggested fix is good and the performance penalty is neglectable as those changes are rare and the module has a high iop_order.
Fixes #22069