Add protection against memory allocation failure in Color balance RGB - #22099
Merged
TurboGit merged 1 commit intoSep 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to check malloc result to prevent NULL-dereferencing and crash.
In this case, the graph in the mask tab remains undrawn. Although the graph is allocated a relatively large amount (not just a few hundred bytes like for some data structure), it is not many megabytes like for image buffers. Accordingly, the probability of not allocating memory of such a limited size is quite small and, in my opinion, it is enough to save the program from crashing, and adding text for dt_control_log probably does not make much practical sense.
For the same reason, this fix is not important enough to be mentioned in the release notes.