Skip to content

Bundle Lua scripts into the darktable release#20848

Merged
TurboGit merged 4 commits into
darktable-org:masterfrom
wpferguson:API_9_7_0_bundle_scripts
Apr 23, 2026
Merged

Bundle Lua scripts into the darktable release#20848
TurboGit merged 4 commits into
darktable-org:masterfrom
wpferguson:API_9_7_0_bundle_scripts

Conversation

@wpferguson
Copy link
Copy Markdown
Member

Supersedes #19899.

This PR enables bundling the lua-scripts with the darktable release, removing the last barrier to entry for using the scripts.

The bundled scripts are the choice of last resort, so if the user already has the lua-scripts installed the user version takes priority.

The scripts can also run in a "hybrid" mode where the bundled scripts are used and selected scripts can be added by placing them in the users lua directory.

Fixes #17422.

@TurboGit TurboGit added this to the 5.6 milestone Apr 23, 2026
@TurboGit TurboGit added feature: redesign current features to rewrite lua labels Apr 23, 2026
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit a507eba into darktable-org:master Apr 23, 2026
5 checks passed
@anoderay
Copy link
Copy Markdown

Could it be that this removed the Lua-installer from darktables UI? When starting with a clean config dir the current nightly neither has lua scripts included nor the installer.

@wpferguson
Copy link
Copy Markdown
Member Author

@anoderay what OS?

@anoderay
Copy link
Copy Markdown

@anoderay what OS?

Sorry: Appimage running on bazzite, observed the same behaviour in a Ubuntu VM.

@wpferguson
Copy link
Copy Markdown
Member Author

wpferguson commented May 11, 2026

I reproduced it on windows because the install directory had a - in it which messed up detection of using the built-in or added lua-scripts. I'll fix that first and see if it clears up the others.

@anoderay can you run with -d lua and post a log?

EDIT: Tested last nights appimage on Ubuntu 22.04 and it worked correctly.

EDIT 2: #20986 will fix the windows problem and my fix the one above.

@tenderlove
Copy link
Copy Markdown
Contributor

It looks like a4003bc causes ~/.config/darktable/luarc to not be executed anymore. Are we expecting script_manager to pick up that file, or is ~/.config/darktable/luarc not supported anymore?

@wpferguson wpferguson deleted the API_9_7_0_bundle_scripts branch May 12, 2026 01:52
@wpferguson
Copy link
Copy Markdown
Member Author

@tenderlove the user luarc should still be respected and used if it's present. Fix coming....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: redesign current features to rewrite lua

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle the lua-scripts with the darktable release

4 participants