[AI] Fix crash with --library :memory: by skipping disk cache#20623
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Mar 22, 2026
Merged
[AI] Fix crash with --library :memory: by skipping disk cache#20623TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20611 :
When darktable runs with
--library :memory:(in-memory database for testing), the disk cache for object mask encoder embeddings crashed becausedt_database_get_path()returns":memory:"which is not a valid filesystem path.The
g_realpath(":memory:")call loggedpath lookup ':memory:' failsand the subsequent cache operations failed.Fix
_get_cache_dir()now returns FALSE when the database is unavailable or in-memory. Callers skip disk cache operations gracefully — encoding still works, just without caching between sessions.