Skip to content

fix: keep large pastes whole and render decomposed Hangul (INC-1281) - #630

Merged
arzafran merged 3 commits into
mainfrom
franco/inc-1281-ghostty-fork-patches
Nov 16, 2026
Merged

arzafran merged 3 commits into
mainfrom
franco/inc-1281-ghostty-fork-patches

Conversation

@arzafran

Copy link
Copy Markdown
Member

Summary

  • Large pastes into a busy program no longer get cut off. When the terminal's write buffer was full, the write failed instead of waiting, and the rest of the paste was lost. Writes now wait and retry, and the first queued write keeps its place.
  • Korean text that arrives decomposed (NFD Hangul, as macOS sometimes produces) now renders as whole syllables instead of separate letters.
  • Both fixes are in our Ghostty fork. This PR moves the pin to fork main at 60f5a29b7 and records the patches in docs/ghostty-fork.md.

Ported from cmux, with one difference. cmux's paste fix retries on WouldBlock, but the libxev version Ghostty pulls reports that error as Unexpected on macOS (kqueue), so the retry would never run. The fork now vendors libxev at upstream 819ffa180 under vendor/libxev, maps the error correctly, and adds the retry. Upstream libxev does not have this fix yet.

The file-descriptor leak fix from the same batch is not included: the fork already has it, and its app-side half changes code Programa does not have.

Linear: INC-1281

Testing

  • Hangul: a new fork test failed before the fix and passes after.
  • libxev: two new tests failed before the fix. The full libxev suite passes after.
  • The ReleaseFast xcframework builds with Zig 0.17.1, and a tagged Debug app builds against it.
  • Not tried in the running app: a real large paste, and typing Korean on screen.
  • deps/packages.* and flatpak/zig-packages.json in the fork still list the libxev tarball. Regenerating them needs Nix, and Programa's GhosttyKit build does not read them.

Checklist

  • Tested via CI
  • I added or updated tests for behavior changes (fork tests)
  • I updated docs/changelog if needed

@arzafran
arzafran merged commit 6d00cfe into main Nov 16, 2026
13 checks passed
@arzafran
arzafran deleted the franco/inc-1281-ghostty-fork-patches branch November 16, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant