Skip to content

fix: restore native window controls - #304

Merged
arzafran merged 5 commits into
mainfrom
fix/native-window-controls
Aug 15, 2026
Merged

fix: restore native window controls#304
arzafran merged 5 commits into
mainfrom
fix/native-window-controls

Conversation

@arzafran

Copy link
Copy Markdown
Member

What this does

Keeps shortcut badges compact and returns traffic-light layout and visibility to AppKit so the controls stay stable through resize, fullscreen, and titlebar changes.

Review order

  1. The shortcut hint pill now sizes to its intrinsic content.
  2. The custom traffic-light frame writer and its lifecycle callbacks are removed.
  3. The regression test verifies that a lifecycle notification cannot translate AppKit's native buttons.

Test plan

  • Tagged Debug build: native-window-controls
  • Regression test recorded red before the production fix in CI run 31849184894
  • Corrected branch CI run 31852193167

@arzafran
arzafran marked this pull request as ready for review August 15, 2026 00:11
@arzafran
arzafran merged commit 9c2b419 into main Aug 15, 2026
10 of 15 checks passed
@arzafran
arzafran deleted the fix/native-window-controls branch August 15, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant