Repository navigation
Conversation
* fix: accept absolute unix socket paths in GrpcEndpoint unix:///path/to.sock and unix:/path/to.sock put the socket path in the parsed URL's path, which the path check rejected, so WorkflowRuntime, DaprWorkflowClient and DaprClient all failed on them. Allow a path for the unix scheme and build the hostname from netloc + path so the filename's case is kept. Signed-off-by: Kayvan Zahiri <kzahiri@dons.usfca.edu> * fix: reject unix:// endpoints with an authority, keep socket name case gRPC needs an absolute path after unix://, so unix://my.sock and unix://rel/dir/x.sock can never connect; raise ValueError instead of hanging until the timeout. Build the hostname from netloc + path for every unix endpoint so unix:My.sock keeps its case. Signed-off-by: Kayvan Zahiri <kzahiri@dons.usfca.edu> --------- Signed-off-by: Kayvan Zahiri <kzahiri@dons.usfca.edu> Co-authored-by: Casper Nielsen <casper@diagrid.io> Co-authored-by: Sam Kendziora <sam@diagrid.io> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> (cherry picked from commit 5564131) Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #1289 +/- ##
===============================================
Coverage ? 86.69%
===============================================
Files ? 163
Lines ? 12931
Branches ? 0
===============================================
Hits ? 11210
Misses ? 1721
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sicoyle
approved these changes
Oct 15, 2026
sicoyle
added
automerge
dapr-bot
enabled auto-merge (squash)
October 15, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 5564131 from #1226.