Repository navigation
[Backport release-1.19] docs: fix contributor setup instructions in AGENTS.md and README.md - #1282
Merged
Merged
Conversation
…1207) * docs: fix contributor setup instructions in AGENTS.md `uv sync --all-packages --group dev` is not enough to run `tests/examples/` or `tests/integration/`. The `tests` group carries the extra dependencies those suites need - `examples/langgraph-checkpointer/agent.py` imports `langchain_ollama`, which only that group installs - and it is what CI syncs for both of those jobs (`.github/workflows/run-tests.yaml`). Following the setup section as written, `pytest tests/examples/` fails with a ModuleNotFoundError. Points the setup section at the `tests` group for those suites and names the requirement in the two command comments. Also corrects the pinned ruff version, which had drifted: AGENTS.md said 0.14.1 in two places while `pyproject.toml` pins `ruff==0.15.19`. Signed-off-by: Sai Kishore Punagani <63619246+saikishore-p@users.noreply.github.com> * docs: apply the tests-group setup fix to README.md README.md's contributor steps sync `--group dev` and then run `tests/integration/` and `tests/examples/`, which need the `tests` group, the same gap fixed in AGENTS.md. Points step 3 at the `tests` group for those suites, with the same wording as AGENTS.md, and names the requirement on steps 7 and 8 so the two guides agree. Signed-off-by: Sai Kishore Punagani <63619246+saikishore-p@users.noreply.github.com> * docs: match the ruff version in AGENTS.md to the 0.16.2 pin Signed-off-by: Sai Kishore Punagani <63619246+saikishore-p@users.noreply.github.com> --------- Signed-off-by: Sai Kishore Punagani <63619246+saikishore-p@users.noreply.github.com> Co-authored-by: Casper Nielsen <casper@diagrid.io> (cherry picked from commit c269cdc) Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #1282 +/- ##
===============================================
Coverage ? 86.68%
===============================================
Files ? 163
Lines ? 12924
Branches ? 0
===============================================
Hits ? 11203
Misses ? 1721
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sicoyle
added
automerge
dapr-bot
enabled auto-merge (squash)
October 15, 2026 13:25
sicoyle
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport c269cdc from #1207.