-
Notifications
You must be signed in to change notification settings - Fork 225
[1.17] make bulk pubsub stable #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.17
Are you sure you want to change the base?
Conversation
… API Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
…ent refs Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #1641 +/- ##
==================================================
- Coverage 79.02% 78.99% -0.04%
- Complexity 2097 2101 +4
==================================================
Files 228 228
Lines 6322 6332 +10
Branches 693 696 +3
==================================================
+ Hits 4996 5002 +6
- Misses 975 978 +3
- Partials 351 352 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@javier-aliaga @salaboy @siri-varma @artur-ciocanu please have a look :) |
javier-aliaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but codecoverage is failing
update all tests/examples/code to the stable API and fallback to alpha API if UNIMPLEMENTED