Actor state save best practices #854

Activity

1. manuelserradev

   added

   kind/bugSomething isn't workingSomething isn't working

   on Apr 27, 2023
2. mukundansundar commented on May 12, 2023

   

   mukundansundar

   on May 12, 2023

   Contributor

   More actions

   @nitroin What is the version of Dapr that you are using? Also what version of SDK are you using?
3. manuelserradev commented on May 12, 2023

   

   manuelserradev

   on May 12, 2023

   Last edited by manuelserradev

   ContributorAuthor

   More actions

   @mukundansundar

   ❯ dapr --version
   CLI version: 1.9.1
   Runtime version: 1.10.5

   Latest SDK version (1.8.0).
4. mukundansundar commented on May 18, 2023

   

   mukundansundar

   on May 18, 2023

   Last edited by mukundansundar

   Contributor

   More actions

   @nitroin Can you check if this happens with 1.10.7 runtime?
   And what actor state store is being used?
5. artursouza commented on May 18, 2023

   

   artursouza

   on May 18, 2023

   Contributor

   More actions

   This error might be inside the ActorStateManager code in SDK and not in runtime.
6. artursouza

   added

   P1

   on May 18, 2023
7. manuelserradev commented on May 26, 2023

   

   manuelserradev

   on May 26, 2023

   Last edited by manuelserradev

   ContributorAuthor

   More actions

   I, also, do think that is not runtime related.

   What I can see is that in the actor-sdk the incorrect type of collection is used (for thread safety and such), but this contradicts with the expectation of the "actor" threading model - but again looks like to me the problem arise from underlying layer (sdk and state interaction).

   That being said I'll do try on the latest runtime.
8. manuelserradev commented on May 26, 2023

   

   manuelserradev

   on May 26, 2023

   ContributorAuthor

   More actions

   I can confirm the same issue with:

   ❯ dapr --version
   CLI version: 1.9.1 
   Runtime version: 1.10.7

   And sdk version 1.8.0.

   I will copy-paste the full actor:

   import com.fasterxml.jackson.databind.ObjectMapper;
   import io.dapr.actors.ActorId;
   import io.dapr.actors.runtime.AbstractActor;
   import io.dapr.actors.runtime.ActorRuntimeContext;
   import io.dapr.client.DaprClient;
   import lombok.extern.slf4j.Slf4j;
   
   @Slf4j
   public class SerializerActorImpl extends AbstractActor implements SerializerActor {
   
     public SerializerActorImpl(ActorRuntimeContext<SerializerActorImpl> runtimeContext, ActorId id) {
       super(runtimeContext, id);
   
       log.info("Actor:%s Initializing...".formatted(id));
     }
   
     public static SerializerActorImpl createActor(
         ActorRuntimeContext<SerializerActorImpl> runtimeContext,
         ActorId id,
         DaprClient daprClient,
         String broker,
         String engineTopic,
         ObjectMapper objectMapper) {
       var actor = new SerializerActorImpl(runtimeContext, id);
   
       return actor;
     }
   
     @Override
     public void enqueue(String taskId) {
   
       var mockPayload = "{}";
   
       this.getActorStateManager().set("payload_%s".formatted(taskId), mockPayload).block();
   
       System.out.println("Saved payload %s".formatted(taskId));
   
       this.saveState().block();
     }
   
     @Override
     public void ack(String taskId) {
   
       var mockPayload =
           this.getActorStateManager().get("payload_%s".formatted(taskId), String.class).block();
   
       System.out.println("Retrieved payload %s".formatted(taskId));
       System.out.println("Payload was %s".formatted(mockPayload));
   
       this.getActorStateManager().remove("payload_%s".formatted(taskId)).block();
   
       this.saveState().block();
     }
   
     @Override
     public String state() {
       return "hello!";
     }
   }

   Controller:

   import io.dapr.actors.ActorId;
   import io.dapr.actors.client.ActorProxyBuilder;
   import lombok.RequiredArgsConstructor;
   import org.springframework.http.ResponseEntity;
   import org.springframework.web.bind.annotation.GetMapping;
   import org.springframework.web.bind.annotation.PathVariable;
   import org.springframework.web.bind.annotation.RestController;
   
   @RestController
   @RequiredArgsConstructor
   public class SerializerActorController {
   
     private final ActorProxyBuilder<SerializerActor> actorProxyBuilder;
   
     @GetMapping(value = "/enqueue/{taskId}")
     public ResponseEntity<Void> enqueue(@PathVariable("taskId") String taskId) {
   
       try {
         var actorId = new ActorId("actorId");
         var actor = actorProxyBuilder.build(actorId);
   
         actor.enqueue(taskId);
   
         return ResponseEntity.ok().build();
       } catch (Exception ex) {
         ex.printStackTrace();
         return ResponseEntity.internalServerError().build();
       }
     }
   
     @GetMapping(value = "/ack/{taskId}")
     public ResponseEntity<Void> ack(@PathVariable("taskId") String taskId) {
   
       try {
         var actorId = new ActorId("actorId");
         var actor = actorProxyBuilder.build(actorId);
   
         actor.ack(taskId);
   
         return ResponseEntity.ok().build();
       } catch (Exception ex) {
         ex.printStackTrace();
         return ResponseEntity.internalServerError().build();
       }
     }
   }

   App config:

   import com.fasterxml.jackson.databind.Module;
   import io.cloudevents.core.provider.ExtensionProvider;
   import io.cloudevents.jackson.JsonFormat;
   import io.dapr.actors.client.ActorClient;
   import io.dapr.actors.client.ActorProxyBuilder;
   import io.dapr.client.DaprClient;
   import io.dapr.client.DaprClientBuilder;
   import org.springframework.context.annotation.Bean;
   import org.springframework.context.annotation.Configuration;
   
   @Configuration
   public class ApplicationConfig {
   
     @Bean
     public Module cloudEventModule() {
       return JsonFormat.getCloudEventJacksonModule();
     }
   
     @Bean
     public ActorClient actorClient() {
       return new ActorClient();
     }
   
     @Bean
     public DaprClient daprClient(CloudEventSerializer asd) {
       return new DaprClientBuilder().withObjectSerializer(asd).build();
     }
   
     @Bean
     public ActorProxyBuilder<SerializerActor> actorProxyBuilder(ActorClient actorClient) {
       return new ActorProxyBuilder<SerializerActor>(SerializerActor.class, actorClient);
     }
   }

   And actor factory, needed to inject app configs into actors:

   import com.fasterxml.jackson.databind.ObjectMapper;
   import io.dapr.actors.ActorId;
   import io.dapr.actors.runtime.ActorFactory;
   import io.dapr.actors.runtime.ActorRuntimeContext;
   import io.dapr.client.DaprClient;
   import lombok.RequiredArgsConstructor;
   import org.springframework.beans.factory.annotation.Value;
   import org.springframework.stereotype.Component;
   
   @Component
   @RequiredArgsConstructor
   public class SerializerActorFactory implements ActorFactory<SerializerActorImpl> {
   
     private final DaprClient daprClient;
   
     private final ObjectMapper objectMapper;
   
     @Value("${dapr.components.pubsub.broker}")
     private String daprBroker;
   
     @Value("${dapr.components.pubsub.topics.out.engine}")
     private String daprOutTopicEngine;
   
     @Override
     public SerializerActorImpl createActor(
         ActorRuntimeContext<SerializerActorImpl> actorRuntimeContext, ActorId actorId) {
       return SerializerActorImpl.createActor(
           actorRuntimeContext, actorId, daprClient, daprBroker, daprOutTopicEngine, objectMapper);
     }
   }
9. fnurglewitz commented on May 26, 2023

   

   fnurglewitz

   on May 26, 2023

   Last edited by fnurglewitz

   More actions

   I'm having the same issue with dapr 1.10

   $ dapr --version
   CLI version: 1.10.0
   Runtime version: 1.10.5
   
10. manuelserradev commented on Feb 20, 2024

    

    manuelserradev

    on Feb 20, 2024

    ContributorAuthor

    More actions

    This error might be inside the ActorStateManager code in SDK and not in runtime.

    @artursouza care to explain a little further? This error still happens and I'd like to understand any actionable on our side.
11. javier-aliaga commented on Oct 15, 2026

    

    javier-aliaga

    on Oct 15, 2026

    Contributor

    More actions

    closed vy #1017
12. javier-aliaga

    closed this as completedon Oct 15, 2026