Skip to content

fix: rename with proto changes#1629

Open
sicoyle wants to merge 4 commits intodapr:masterfrom
sicoyle:fix/updates-from-renames
Open

fix: rename with proto changes#1629
sicoyle wants to merge 4 commits intodapr:masterfrom
sicoyle:fix/updates-from-renames

Conversation

@sicoyle
Copy link
Copy Markdown
Contributor

@sicoyle sicoyle commented Apr 9, 2026

Description

Precursor to #1628 that I stumbled upon in testing my local changes.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Samantha Coyle <sam@diagrid.io>
Copilot AI review requested due to automatic review settings April 9, 2026 19:46
@sicoyle sicoyle requested review from a team as code owners April 9, 2026 19:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the CLI’s workflow history parsing/output with upstream Durable Task / Dapr proto renames, and bumps Go module dependencies to versions that include those proto changes.

Changes:

  • Update workflow history event handling to use renamed proto fields/events (e.g., WorkflowInstance, WorkflowStarted, ChildWorkflowInstance*).
  • Update workflow status mapping to the renamed WorkflowStatus field.
  • Bump Dapr/DurableTask-Go (and related) module versions in go.mod/go.sum.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pkg/workflow/history.go Renames proto event/field usage for workflow history display and derived metadata.
go.mod Updates Go module versions to pull in proto changes; includes an extra trailing comment.
go.sum Records checksum updates for the dependency version changes.
Comments suppressed due to low confidence (1)

go.mod:275

  • The trailing commented-out local replace github.com/dapr/dapr => ../dapr looks like a leftover from local development. Please remove it before merging to avoid confusion about the module's intended dependency graph.
	sigs.k8s.io/controller-runtime v0.19.0 // indirect
	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
	sigs.k8s.io/kustomize/api v0.19.0 // indirect

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sicoyle added 2 commits April 10, 2026 11:06
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants