Open
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Aligns the CLI’s workflow history parsing/output with upstream Durable Task / Dapr proto renames, and bumps Go module dependencies to versions that include those proto changes.
Changes:
- Update workflow history event handling to use renamed proto fields/events (e.g.,
WorkflowInstance,WorkflowStarted,ChildWorkflowInstance*). - Update workflow status mapping to the renamed
WorkflowStatusfield. - Bump Dapr/DurableTask-Go (and related) module versions in
go.mod/go.sum.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/workflow/history.go | Renames proto event/field usage for workflow history display and derived metadata. |
| go.mod | Updates Go module versions to pull in proto changes; includes an extra trailing comment. |
| go.sum | Records checksum updates for the dependency version changes. |
Comments suppressed due to low confidence (1)
go.mod:275
- The trailing commented-out local
replace github.com/dapr/dapr => ../daprlooks like a leftover from local development. Please remove it before merging to avoid confusion about the module's intended dependency graph.
sigs.k8s.io/controller-runtime v0.19.0 // indirect
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
sigs.k8s.io/kustomize/api v0.19.0 // indirect
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Precursor to #1628 that I stumbled upon in testing my local changes.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: