fix(ci): trigger CLI build after creating release tag#1626
Open
nelson-parente wants to merge 2 commits intomasterfrom
Open
fix(ci): trigger CLI build after creating release tag#1626nelson-parente wants to merge 2 commits intomasterfrom
nelson-parente wants to merge 2 commits intomasterfrom
Conversation
Tags pushed by a workflow's token don't reliably trigger other workflows (known GitHub Actions limitation). This meant dapr_cli.yaml never fired after create-release.yaml pushed the tag, requiring manual tag pushes to cut CLI releases. Add a trigger job (same pattern as dapr/dapr) that explicitly calls gh workflow run dapr_cli.yaml after the tag is created. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Without workflow_dispatch, the create-release trigger job cannot invoke this workflow via gh workflow run. This is required for the create-release automation to work. Matches dapr/dapr's dapr.yml which already has workflow_dispatch. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
acroca
reviewed
Apr 10, 2026
| env: | ||
| GITHUB_TOKEN: ${{ secrets.DAPR_BOT_TOKEN }} | ||
| run: | | ||
| gh workflow run dapr_cli.yaml --repo dapr/cli --ref v$(echo '${{ inputs.rel_version }}' | sed -r 's/^[vV]?([0-9].+)$/\1/') |
Member
There was a problem hiding this comment.
I think it'd be better to use the workflow_call approach instead.
When using workflow_call in the target workflow, we can invoke it with uses: ./.github/workflows/dapr_cli.yml, and it runs the workflow as part of the current workflow, so if the dapr_cli workflow fails, the release workflow will also show red.
Maybe we prefer to keep it consistent with dapr/dapr, but I think the workflow_call approach is better in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
triggerjob tocreate-release.yamlthat explicitly callsgh workflow run dapr_cli.yamlafter the tag is createddapr/dapr(see trigger job)