Open
Conversation
|
Hey Alex, would you be able/willing to commit the fix you mention to a branch on your fork? I have the tests freezing locally in node 5 and I dearly want them to work, but I'm busy trying to merge the other outstanding pull requests from here into my fork (https://github.com/BryanDollery/arresting), so I don't have a lot of time to investigate. For me the tests are freezing on the first 'retry' test. |
Author
|
I believe this is what I was talking about: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for running the tests on Travis CI. I'm opening this PR because the tests do not complete when running on Node v4 and v5. I have a fix for that issue as well, but wanted to get these multiple build targets working first so you could see where it's wedging.