Fix #14657 report type: handle id suffix better when getting guideline number#8426
Open
wjakobsson wants to merge 2 commits intodanmar:mainfrom
Open
Fix #14657 report type: handle id suffix better when getting guideline number#8426wjakobsson wants to merge 2 commits intodanmar:mainfrom
wjakobsson wants to merge 2 commits intodanmar:mainfrom
Conversation
danmar
reviewed
Apr 8, 2026
lib/errorlogger.cpp
Outdated
Comment on lines
+1084
to
+1088
| auto dashPos = errId.rfind('-'); | ||
| while (dashPos != std::string::npos && isalpha(errId[dashPos + 1])) { | ||
| dashPos = errId.rfind('-', dashPos - 1); | ||
| } | ||
| guideline = errId.substr(dashPos + 1, errId.find('-', dashPos + 1) - dashPos - 1); |
Owner
There was a problem hiding this comment.
hmm I don't have a very strong opinion but an alternative could be something like:
auto pos1 = errId.find("20") + 5;
if (errId.compare(pos1,4,"dir-",0,4) == 0)
pos1 += 4;
const auto endpos = errId.find('-', pos1);
guideline = errId.substr(pos1, endpos-pos1);
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (errId.compare(pos1,4,"dir-",0,4) == 0) | ||
| pos1 += 4; | ||
| const auto endpos = errId.find('-', pos1); | ||
| guideline = errId.substr(pos1, endpos-pos1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.