Fix #11389 unnecessary trunc long cast return - part2#8243
Draft
ceJce wants to merge 5 commits intodanmar:mainfrom
Draft
Fix #11389 unnecessary trunc long cast return - part2#8243ceJce wants to merge 5 commits intodanmar:mainfrom
ceJce wants to merge 5 commits intodanmar:mainfrom
Conversation
added astutils functions for getting expression max min values and a check if bigint within int range.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (op->str() == "<<") { | ||
| // If the lefthand operand is 31 or higher the resulting shift will be a negative value or greater than int range. | ||
| if ((rightRange->first >= INTEGER_SHIFT_LIMIT) || rightRange->second >= INTEGER_SHIFT_LIMIT) |
Check warning
Code scanning / Cppcheck Premium
An unsigned arithmetic operation with constant operands should not wrap Warning
|
|
||
| if (op->str() == "<<") { | ||
| // If the lefthand operand is 31 or higher the resulting shift will be a negative value or greater than int range. | ||
| if ((rightRange->first >= INTEGER_SHIFT_LIMIT) || rightRange->second >= INTEGER_SHIFT_LIMIT) |
Check warning
Code scanning / Cppcheck Premium
An unsigned arithmetic operation with constant operands should not wrap Warning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.