Skip to content

Retry transient Vale download failures - #78

Open
adamtheturtle wants to merge 5 commits into
daniperez:mainfrom
adamtheturtle:retry-transient-downloads
Open

adamtheturtle wants to merge 5 commits into
daniperez:mainfrom
adamtheturtle:retry-transient-downloads

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Sep 14, 2026 •

Copy link
Copy Markdown

Closes #77.

Retry URL errors, timeouts, HTTP 408/429, and HTTP 5xx responses up to five attempts. Each request uses a 60-second timeout; retries wait for exponential backoff (2, 4, 8, and 16 seconds) plus 0–10 seconds of jitter. Permanent HTTP errors still fail immediately, and retry messages include the failure reason and HTTP status where applicable.

Validation: source and wheel builds; fresh wheel installation followed by a successful Vale download and vale --help.

@adamtheturtle
adamtheturtle force-pushed the retry-transient-downloads branch from 7bcb299 to 9797611 Compare September 14, 2026 11:18

@daniperez daniperez left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @adamtheturtle ! And thanks for waiting on it for so long 😅

I allowed myself to suggest a couple of changes. Would you be so kind to review them? Let me know what you think.

Comment thread vale/main.py Outdated
Comment thread vale/main.py Outdated
Comment thread vale/main.py Outdated
Comment thread CHANGELOG.md
Comment thread vale/main.py Outdated
Comment thread vale/main.py Outdated
@adamtheturtle

Copy link
Copy Markdown
Author

Thank you @daniperez !

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry transient errors when downloading the Vale binary

2 participants