Repository navigation
ci: pin pr-agent action by digest and resolve minimatch advisory - #316
Merged
Merged
Conversation
added 2 commits
November 8, 2026 08:30
The pr-review workflow referenced docker://pragent/pr-agent by a mutable tag (0.36.0-github_action) while passing DEEPSEEK_API_KEY and GITHUB_TOKEN to it. A repointed tag could run an image that exfiltrates those secrets. Pin to the immutable 0.36.0-github_action digest, matching the SHA-pinning every other action in this repo already uses. Resolves the CI/CD Pipeline Audit supply-chain/secrets-exposure finding (8a).
The Dependabot Updates security job failed with security_update_not_possible: the minimatch advisory requires >= 11.0.1, but @ctxo/lang-typescript pins it to ^10.0.1 via @ts-morph/common@0.29.0, so Dependabot could not bump it automatically. Add the npm override its own error message recommends, forcing minimatch to ^11.0.1 (resolves to 11.0.5, 0 vulnerabilities). minimatch is pulled only by the dev-only @ts-morph/common tooling; v11's major bump just dropped Node < 20 (CI and the VPS run Node 24) and keeps the same API, verified against its usage.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Resolves two pending CI/CD problems, one commit each.
1. CI/CD Pipeline Audit — supply-chain / secrets exposure (critical)
pr-review.yamlreferenced the third-party review bot by a mutable tag(
docker://pragent/pr-agent:0.36.0-github_action) while handing itDEEPSEEK_API_KEYandGITHUB_TOKEN. If that tag were repointed, acompromised image could run with those secrets. This was the only unpinned
action in the repo — every other action is already SHA-pinned.
Fix: pin the image to its immutable digest
(
@sha256:0e0ab10b…, tagged0.36.0-github_action). Clears audit finding 8aand the "secrets exposed" critical. Validated with
actionlint(clean).2. Dependabot Updates workflow —
security_update_not_possible(error)The security job failed because the
minimatchadvisory requires>= 11.0.1,but
@ctxo/lang-typescriptpins it to^10.0.1via@ts-morph/common@0.29.0,so Dependabot could not bump it automatically
(run).
Fix: add the npm
overridesentry Dependabot's own error recommends,forcing
minimatchto^11.0.1(resolves to11.0.5,0 vulnerabilities).minimatchis pulled only by the dev-only@ts-morph/commontooling; v11'smajor bump dropped Node < 20 (CI and the VPS run Node 24) and keeps the same
API, verified against its usage.
Verification
actionlinton all workflows — clean (pre-existing SC2012 notes untouched)npm ci --ignore-scripts— clean,found 0 vulnerabilitiesnpm ci --dry-run) — in syncgo build ./...— success (no Go source touched)🤖 Generated with Claude Code
PR Type
Bug fix
Description
Pin pr-agent GitHub Action by immutable digest
Add npm override to force minimatch ^11.0.1
Mitigate secrets exposure and resolve Dependabot advisory
Diagram Walkthrough
File Walkthrough
pr-review.yaml
Pin pr-agent action to immutable digest.github/workflows/pr-review.yaml
package.json
Override minimatch to resolve advisorypackage.json