Skip to content

fix(interceptor): publish captures from staged save - #2015

Open
mj-deving wants to merge 1 commit into
danielmiessler:mainfrom
mj-deving:codex/interceptor-capture-save
Open

fix(interceptor): publish captures from staged save#2015
mj-deving wants to merge 1 commit into
danielmiessler:mainfrom
mj-deving:codex/interceptor-capture-save

Conversation

@mj-deving

Copy link
Copy Markdown

Summary

  • stop passing unsupported --out to interceptor screenshot
  • run --json ... --save from a private same-filesystem staging directory
  • parse and validate the returned filePath, reject blank captures, and publish with atomic rename semantics
  • preserve an existing destination when capture, validation, or publication fails

Why

Interceptor 0.23.30 exposes --save for screenshots and returns the actual filePath; it does not expose screenshot --out. The wrapper currently forwards --out, so the required screenshot verification fails before producing an image.

Testing

  • bash -n LifeOS/install/skills/Interceptor/Tools/Capture.sh
  • shellcheck LifeOS/install/skills/Interceptor/Tools/Capture.sh
  • targeted 11-case regression harness covering DOM and forced-pixel invocation, custom/default destinations, JSON escaping, blank rejection, cleanup, preflight failure, publication failure, untrusted filePath, and destination-symlink substitution
  • live Interceptor 0.23.30 DOM capture produced a valid 3034×1680 PNG at the requested path
  • verified pinned Interceptor commit fe94108 writes successful DOM and pixel --save payloads in the CLI working directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant