feat: add /highlights page with channel navigation#5857
Merged
Conversation
Add a dedicated /highlights page with channel tab navigation, replacing the inline highlight modal. Each highlight is collapsible (title + TLDR) and links back to the post. Highlight cards in the feed now link directly to the highlights page with deep-linking support via query params. - New /highlights page with ISR and SEO - Dynamic /highlights/[channel] subpages per channel - Tab navigation with swipe support (generic TabContainer feature) - Shallow routing for smooth tab transitions - Remove HighlightPostModal and all related infrastructure
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Show a bell icon above channel highlights to subscribe to the channel's digest. Single toggle: click follows + enables notifications if not subscribed, or disables notifications if already subscribed. Includes a skeleton placeholder to prevent layout shift while user state loads.
idoshamun
commented
Apr 14, 2026
Comment on lines
+57
to
+60
| if (haveNotificationsOn) { | ||
| await onNotify(); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Why do we have this condition?
idoshamun
commented
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/highlightspage with "Happening Now" header and channel tab navigation/highlights/[channel]subpages with ISR (revalidate: 60s)?highlight=id)TabContainerfeature viaswipeableprop)shallowprop onTabContainer)HighlightPostModaland all related modal infrastructure (7 files deleted, ~1000 lines removed)Test plan
/highlights— verify Headlines tab loads with major highlights/highlights?highlight=idwith that item expandedPreview domain
https://feat-highlights-page.preview.app.daily.dev