Add configurable auto-insert pairing - #1098
Open
saberoueslati wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you for your PRs as always. I think as a first implementation of this, I think this can be simplified quite a bit. I'm a bit hesitant to capture keyboard events unless its absolutely needed. The Notepad++ implementation of this just gets triggred from the SCN_CHARADDED notification and that has seemed to work for the project pretty well. It would be nice to get rid of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1085
This PR adds configurable automatic insertion of matching delimiters for parentheses, square brackets, curly braces, single quotes, and double quotes.
The feature creates and tracks generated closers so users can type through them, remove an empty generated pair with Backspace, and retain the expected behavior through Undo and Redo. The settings apply immediately to already-open editors.
HTML/XML closing-tag completion is now configurable through the same Auto-Insert preferences section. It remains enabled by default to preserve the existing behavior and now works in both HTML and XML documents.
Changes Made
()[]{}''""AutoInsertDecoratorto handle pair insertion, generated-closer overtyping, paired Backspace, and Undo/Redo tracking.Testing
Manual test plan :
TestPlan-AutoInsert.md
Coverage includes:
Video of basic manual test below :
Screencast.from.2026-07-25.22-39-40.webm